Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enable 'fetch' adapter + duplicate request params fix #483

Merged
merged 1 commit into from
Jul 3, 2024
Merged

feat: enable 'fetch' adapter + duplicate request params fix #483

merged 1 commit into from
Jul 3, 2024

Conversation

t-col
Copy link
Contributor

@t-col t-col commented Jul 3, 2024

  • enables consumers of this package (CDA.js and CMA.js) to instantiate axios clients using the new fetch adapter that was introduced in axios 1.7.0
  • fixes a bug that was introduced with the upgrade of axios version from 1.6.8 to 1.7.x

@t-col t-col marked this pull request as ready for review July 3, 2024 20:27
@t-col t-col requested a review from a team as a code owner July 3, 2024 20:27
@t-col t-col enabled auto-merge July 3, 2024 20:28
@t-col t-col merged commit 706d7b6 into master Jul 3, 2024
5 checks passed
@t-col t-col deleted the fix/retries branch July 3, 2024 20:30
@contentful-automation
Copy link

🎉 This PR is included in version 8.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

This was referenced Sep 2, 2024
Open
Closed
Merged
t-col pushed a commit that referenced this pull request Sep 16, 2024
@spzSource
fix: do not remove query parameters on retry (#514)
fbc7975 
Fixes #513.
This is a draft fix intended to start the discussion.

I'm not sure if it's okay to remove the existing hack introduced in
#483. Before making a decision, I’d like to learn more about the
duplicate request parameters problem and how I can reproduce it in a
test.

@t-col probably you could give me some hints?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjolton-contentful jjolton-contentful jjolton-contentful approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@t-col @jjolton-contentful